Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom magnification reversed #57

Open
bfrymire opened this issue Jan 21, 2024 · 0 comments
Open

Zoom magnification reversed #57

bfrymire opened this issue Jan 21, 2024 · 0 comments
Labels
bug Something isn't working v2.3.2

Comments

@bfrymire
Copy link
Collaborator

bfrymire commented Jan 21, 2024

Zoom factors greater than 1 should mean zooming in, thus making things bigger on the screen. The way that STANNcam's zoom factors work is that factors lower than 1 zoom in.

Runner_dBpRohRFpQ

I think reversing how zoom factors work will be more inline with people's expectations when using camera zooms.

Implementing this change should be as simple as flipping a couple of signs. However, making this change can break the zoom controls on existing projects using STANNcam. This change will technically be a major change because it breaks current functionality.

A possible solution to include backwards compatibility would be to add a global flag for which zoom magnification type you want to use.

@jack27121 jack27121 added v2.3.1 enhancement New feature or request labels Apr 30, 2024
@bfrymire bfrymire added bug Something isn't working and removed enhancement New feature or request labels May 4, 2024
@jack27121 jack27121 added v2.3.2 and removed v2.3.1 labels May 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.3.2
Projects
None yet
Development

No branches or pull requests

2 participants