Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardise how we use SVGs #1082

Closed
mattseddon opened this issue Nov 24, 2021 · 1 comment · Fixed by #1102
Closed

Standardise how we use SVGs #1082

mattseddon opened this issue Nov 24, 2021 · 1 comment · Fixed by #1102
Assignees
Labels
A: experiments Area: experiments table webview and everything related A: plots Area: plots webview, side panel and everything related 🏠 housekeeping

Comments

@mattseddon
Copy link
Member

From #1078, #1073 & #1081 we now have 3 different ways of getting SVG inline into our webviews. They are:

  1. Use @svgr/cli to create a React components from webview/icons and check it into source control (Icon component #1081)
  2. Use @svgr along with webpack to load svgs in when bundling (Add copy button #1073)
  3. Use background-image: url in scss and have webpack bundle svg (Update queued experiment icons #1078)

We should standardise and use a single approach for all of the places where we use SVGs.

My preference would be 1. I personally have no idea how to convert 3 to either 1 or 2 though.

@mattseddon mattseddon added A: experiments Area: experiments table webview and everything related A: plots Area: plots webview, side panel and everything related webview 🏠 housekeeping labels Nov 24, 2021
@mattseddon
Copy link
Member Author

I believe we only have two different ways of doing this now. 1 & 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: experiments Area: experiments table webview and everything related A: plots Area: plots webview, side panel and everything related 🏠 housekeeping
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants