Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code repitition #13

Open
o-t-w opened this issue Mar 14, 2019 · 1 comment
Open

Code repitition #13

o-t-w opened this issue Mar 14, 2019 · 1 comment

Comments

@o-t-w
Copy link

o-t-w commented Mar 14, 2019 •
edited
Loading

Currently I'm trying to structure a React Ionic app and am struggling so was looking to this as a reference.
Why is this bit of code repeated for loads of components? Obviously you want it on all those pages, but shouldn't it just be rendered for all routes so you don't have to keep repeating it? <IonHeader> <IonToolbar> <IonButtons slot="start"> <IonMenuButton></IonMenuButton> </IonButtons> <IonTitle>Login</IonTitle> </IonToolbar> </IonHeader>
@mayconmesquita
Copy link

Yes, you don't need to repeat all code. To get a single for all routes, you can use a HOC and change the content (title and its inner buttons).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@o-t-w @mayconmesquita