Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#7 Added more special cases to extarrange script. #34

Closed
wants to merge 5 commits into from

Conversation

aryamagarwal
Copy link

@aryamagarwal aryamagarwal commented Mar 15, 2024

Fixes #7
Added few more special cases for grouping rar, doc, img and mp3 files.

@aryamagarwal aryamagarwal changed the title added more special cases to extarrange script. Solved #7 #7 Added more special cases to extarrange script. Mar 15, 2024
@rootCircle
Copy link
Member

hi @aryamagarwal

egrep is obsolescent, it is recommended that you replace usage of egrep with grep -E

egrep: warning: egrep is obsolescent; using grep -E
grep: warning: * at start of expression

Also, check if the directory already exists, before creating one, so you save on an error!

ping me here when you're done with those, so we can move forward with your PR!

@aryamagarwal
Copy link
Author

@rootCircle I have made required changes. Kindly review it.

@rootCircle
Copy link
Member

LGTM 👍 Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more special cases in extarrange script.
2 participants