Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags section fix #8

Open
akshat-bhansali opened this issue Mar 14, 2024 · 5 comments
Open

Tags section fix #8

akshat-bhansali opened this issue Mar 14, 2024 · 5 comments
Assignees
Labels
bug Something isn't working enhancement New feature or request hard

Comments

@akshat-bhansali
Copy link
Contributor

The tags section present in the current user's page needs its UI to be fixed.
The "SAVE" button only enables when there is some change in the tags.Color changes from red to blue when button is enabled.
Changes to be made :-

  1. "SAVE" and "TAGS" button height shouldn't increase or decrease when tags are added or removed respectively.
  2. The tags which are already present in the list shouldn't be present in the dropdown.
  3. Add padding to selected tags.
Screenshot 2024-03-14 at 11 22 20 PM
@akshat-bhansali akshat-bhansali added bug Something isn't working enhancement New feature or request hard labels Mar 14, 2024
@0PrashantYadav0
Copy link

@akshat-bhansali i would like to work on this so please aassign this to me

@akshat-bhansali
Copy link
Contributor Author

@0PrashantYadav0 please explain me your approach first

@0PrashantYadav0
Copy link

@akshat-bhansali

  1. For button and tag height, we just have to put it inside another div so that it will not grow in size after adding.
  2. As there are only 2 element in tag list so it will be easy to render the dropdown on condition that they are present at userTags[0] || userTags[1]
  3. Padding will adjust using tailwind.

This will be my approach
Screenshot 2024-03-15 at 3 43 10 PM

@akshat-bhansali
Copy link
Contributor Author

Sounds good,before using userTags [1] just check if there are 2 tags assigned at that point or else it will give run time error
I am assigning you the issue 👍🏻

@0PrashantYadav0
Copy link

@akshat-bhansali
i have create a PR in which i have fixed all the bugs and make changes as per the need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request hard
Projects
None yet
Development

No branches or pull requests

2 participants