Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for setting onlyHandleClicksForHighlightedSamples in gCNV track #1917

Conversation

jethror1
Copy link
Contributor

Summary

From previous discussion, I remembered there being an option to disable pop up labels when clicking on non highlighted samples. This would be really useful where only a single highlighted sample is being displayed, but wanting to keep a full run of unlabelled and unhighlighted sample traces in grey to the background. I tried adding this to the bed file header but it did not seem to work.

I know this can be set via the track config when initialising the browser window, but this does not work when using things such as IGV web app for loading files.

Example header of file:

track type=gcnv height=500 onlyHandleClicksForHighlightedSamples=true highlight=sample_1;red highlight=mean;blue highlight=mean_plus_std;#0B2559 highlight=mean_minus_std;#0B2559 highlight=mean_plus_std2;#36BFB1 highlight=mean_minus_std2;#36BFB1

Example showing the unlabeled and unhighlighted samples are still visible on click:
image

Changes

  • Added an additional check for onlyHandleClicksForHighlightedSamples being defined in bed file header line, and if present setting this to the config object

Testing

Built locally with proposed changes and started up the test browser with npx http-server, loaded the test file and the behaviour is as expected. I have attached a minimal test bed of just chromosome X that I used for testing.

test.gcnv.bed.gz

Example of it working:

igv_js.mp4

@jrobinso jrobinso merged commit 3555019 into igvteam:master Nov 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants