This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Compartmentalise icekit's bower deps #307
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markfinger
commented
Oct 31, 2017
| <link rel="stylesheet" href="{% static 'admin/css/base.css' %}" /> | ||
| <link type="text/less" rel="stylesheet" href="{% static 'admin/css/icekit_dashboard.less' %}" /> | ||
| <link type="text/less" rel="stylesheet" href="{% static 'admin/css/override.less' %}" /> | ||
| {% endcompress %} | ||
| <link rel="stylesheet" href="//maxcdn.bootstrapcdn.com/font-awesome/4.6.3/css/font-awesome.min.css"> | ||
| <link rel="stylesheet" href="{% static 'icekit/bower_components/font-awesome/css/font-awesome.css' %}"> |
There was a problem hiding this comment.
This is an incidental fix that I've been meaning to make for at least a year.
There's no benefit to using a CDN for the admin, and it adds another point of failure.
My guess is that it was added in by Pat during initial prototyping and no one has never corrected it.
|
Edit: all is well in docker-town Looks like the docker build needs some tweaks. I had assumed that the Just waiting on travis to do its thing... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: #286
The intention here is to keep all of icekit's deps within icekit itself, so that the project can define common url paths ("bootstrap/...", for example) without impacting on the admin's functionality.
Basically, we're using a
.bowerrcfile that tells bower to install all of the deps into aicekit/bower_componentsdir within icekit's static dir. All of the asset references have been updated to target that directory.