Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove ImpalaTable subclass #9365

Open
jcrist opened this issue Jun 12, 2024 · 1 comment · May be fixed by #9840
Open

refactor: remove ImpalaTable subclass #9365

jcrist opened this issue Jun 12, 2024 · 1 comment · May be fixed by #9840
Labels
breaking change Changes that introduce an API break at any level impala The Apache Impala backend

Comments

@jcrist
Copy link
Member

jcrist commented Jun 12, 2024

We used to have a few ibis.Table subclasses adding backend-specific functionality to a Table object. These have all been removed except for ImpalaTable. We should remove this to standardize things across backends.
@jcrist
Copy link
Member Author

jcrist commented Jun 12, 2024

I'd vote we delete this for 10.0 as a clean break. Deprecating seems hard and not worth it - we have few impala users, and I'd guess even fewer of them are using these special methods.

@jcrist jcrist added impala The Apache Impala backend breaking change Changes that introduce an API break at any level labels Jun 12, 2024
@jcrist jcrist linked a pull request Aug 14, 2024 that will close this issue
Open
@gforsyth gforsyth moved this from backlog to review in Ibis planning and roadmap Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change Changes that introduce an API break at any level impala The Apache Impala backend
Projects
Ibis planning and roadmap
Status: review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(impala): remove impala table jcrist/ibis
1 participant
@jcrist