This repository has been archived by the owner on Mar 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting a test failure:
Not 100% sure if it's related. |
I think it's just a breaking change in pandas. Probably need to update that test. |
I'm also seeing this error in the CI output. Locally I ran against Ibis 1.2, but looks like maybe the CI is running against 2.0?
|
tswast
added
run-ci
Code has been reviewed and is deemed safe to run
and removed
run-ci
Code has been reviewed and is deemed safe to run
labels
Nov 23, 2021
tswast
approved these changes
Nov 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
github-actions
bot
removed
the
run-ci
Code has been reviewed and is deemed safe to run
label
Nov 23, 2021
tswast
added
run-ci
Code has been reviewed and is deemed safe to run
and removed
run-ci
Code has been reviewed and is deemed safe to run
labels
Nov 23, 2021
github-actions
bot
removed
the
run-ci
Code has been reviewed and is deemed safe to run
label
Nov 23, 2021
github-actions
bot
removed
the
run-ci
Code has been reviewed and is deemed safe to run
label
Nov 23, 2021
That's correct. I've just updated it to only run against 1.x on the v1 branch. Work is still in progress to support Ibis 2.x. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #94.