Add timediff as another time operationr function #92
Conversation
|
From what I can tell, bigquery's class TimeDiff(BinaryOp):
left = Arg(rlz.time)
right = Arg(rlz.time)
output_type = rlz.shape_like('left', dt.Interval('s'))If I understand ibis correctly, this should always return something like I don't think thats what your code is doing? I don't think you can use |
|
I just added the full class TimestampDiff(ValueOp):
left = Arg(rlz.timestamp)
right = Arg(rlz.timestamp)
unit = Arg(rlz.string)
output_type = rlz.shape_like("left", dt.float64)
def timestamp_diff(left, right, unit):
return TimestampDiff(left, right, unit).to_expr()
TimestampValue.timestamp_diff = timestamp_diff
@compiles(TimestampDiff)
def _timestamp_diff(translator, expr):
left, right, unit = expr.op().args
t_left = translator.translate(left)
t_right = translator.translate(right)
# This part is specific to our project where the argument will be an ibis.literal string
t_unit = _timestamp_units[translator.translate(unit).replace("'", "")]
return f"TIMESTAMP_DIFF({t_left}, {t_right}, {t_unit})"I am not sure whether we can do the same in this project since as I said above the standard ibis functionality works differently (I think). |
|
I think to replace the standard ibis def _compile_timestamp_diff_op(op, bq_func, unit):
def diff(translator, expr):
left, right = expr.op().args
t_left = translator.translate(left)
t_right = translator.translate(right)
return f"{bq_func}({t_left}, {t_right}, {unit})"
return compiles(op)(diff)
_compile_timestamp_diff_op(TimestampDiff, "TIMESTAMP_DIFF", "SECOND")
_compile_timestamp_diff_op(TimeDiff, "TIME_DIFF", "SECOND")
_compile_timestamp_diff_op(DateDiff, "DATE_DIFF", "DAY")Or just add them to the registry directly. |
|
I'm confused, what is the difference between this and calling a |
|
Well have you tried compiling this with bigquery? At least at the time of writing few months ago I would get a |
closes #41
baed on https://cloud.google.com/bigquery/docs/reference/standard-sql/time_functions#time_diff and https://github.com/ibis-project/ibis-bigquery/pull/40/files#r620526603 I added a
TIME_DIFFhey @tswast I tried adding a unit test but it is not working :(
I am getting the following errors
any suggestions/advice please?