Merge pull request #78 from iMicknl/various_fixes

iMicknl · Jun 22, 2020 · 91bffec · 91bffec
2 parents 64d40be + 9f6efea
commit 91bffec
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -11,13 +11,18 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Added support for Gate devices
 - Added support for AirSensor devices
 - Added support for ElectricitySensor devices
+- Added support for TemperatureSensor devices
 - Added support for Curtain devices
 - Added support for Generic devices (cover)
 - Added support for SwingingShutter devices
+- Added support for 'up' and 'down' commands for covers
+- Added tilt_position support for covers
+- Added support for 'setRGB' commands for lights
 
 ### Changed
 
 - Removed all hardcoded device strings from the cover component
+- Update state after a command has been succesfully executed
 
 ## [1.0.0] - 04-06-2020
 

diff --git a/custom_components/tahoma/config_flow.py b/custom_components/tahoma/config_flow.py
@@ -7,12 +7,11 @@
 from homeassistant import config_entries, core, exceptions
 from homeassistant.const import CONF_PASSWORD, CONF_USERNAME
 
-from .const import DOMAIN  # pylint:disable=unused-import
+from .const import DOMAIN
 from .tahoma_api import TahomaApi
 
 _LOGGER = logging.getLogger(__name__)
 
-# TODO adjust the data schema to the data that you need
 DATA_SCHEMA = vol.Schema(
     {vol.Required(CONF_USERNAME): str, vol.Required(CONF_PASSWORD): str}
 )

diff --git a/custom_components/tahoma/cover.py b/custom_components/tahoma/cover.py
@@ -318,12 +318,12 @@ def stop_cover(self, **kwargs):
         if "stop" in self.tahoma_device.command_definitions:
             return self.apply_action("stop")
 
-        if "my" in self.tahoma_device.command_definitions:
-            return self.apply_action("my")
-
         if "stopIdentify" in self.tahoma_device.command_definitions:
             return self.apply_action("stopIdentify")
 
+        if "my" in self.tahoma_device.command_definitions:
+            return self.apply_action("my")
+
     def stop_cover_tilt(self, **kwargs):
         """Stop the cover."""
 
@@ -345,7 +345,11 @@ def supported_features(self):
         if "openSlats" in self.tahoma_device.command_definitions:
             supported_features |= SUPPORT_OPEN_TILT
 
-            if "stop" in self.tahoma_device.command_definitions:
+            if (
+                "stop" in self.tahoma_device.command_definitions
+                or "stopIdentify" in self.tahoma_device.command_definitions
+                or "my" in self.tahoma_device.command_definitions
+            ):
                 supported_features |= SUPPORT_STOP_TILT
 
         if "closeSlats" in self.tahoma_device.command_definitions: