Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fences according to spec #105

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

UjinT34
Copy link
Contributor

@UjinT34 UjinT34 commented Nov 11, 2024

  • setExplicitOutFence is never called and doesn't really set the fence. Renamed it to reflect the real purpose
  • changed fence type to int32_t

prop_out_fence_ptr

Sync File fd pointer representing the outgoing fences for a CRTC. Userspace should provide a pointer to a value of type s32, and then cast that pointer to u64.
https://www.kernel.org/doc/html/v6.11/gpu/drm-kms.html
https://drmdb.emersion.fr/properties/3435973836/OUT_FENCE_PTR
https://drmdb.emersion.fr/properties/4008636142/IN_FENCE_FD

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

abi break

@vaxerski vaxerski added the abi break breaks abi label Nov 11, 2024
@vaxerski vaxerski merged commit 545f506 into hyprwm:main Nov 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abi break breaks abi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants