Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching #2

Open
autarch opened this issue Apr 16, 2020 · 2 comments
Open

Caching #2

autarch opened this issue Apr 16, 2020 · 2 comments

Comments

@autarch
Copy link
Member

autarch commented Apr 16, 2020

Caching tidy/lint checks between runs would be great.

Some things to think about ...

Caching should be per filter and then per file/dir.

The cache key should include file (or dir) checksum, precious binary checksum, filter config, and checksum of the filter's binary.

@spazm
Copy link

spazm commented Jun 26, 2020

Some linters and tidiers implement their own caching, could that be leveraged? Would it be worth the hassle of keeping track of which ones did vs didn't? Does cargo fmt do any caching detection I wonder?

You've got me thinking about the adage that all projects end up as either an email client or a poor re-implementation of Make.

At a minimum threshold, this will need to work better than make -j ... would work, assuming that the linter and tidier dropped some sort of stub output for the make rules. (Implementing checksums would automatically pass that bar.)

@autarch
Copy link
Member Author

autarch commented Jun 27, 2020

It'd certainly be easy enough to support a use_cache = false option for filters that implement their own caching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants