Add a temporary workaround to get building on Node 18 since Node 16 EOL is 2023-09-11 #6053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…OL is 2023-09-11 This does the following: * Add NODE_OPTIONS=--openssl-legacy-provider (not needed once we upgrade to react-scripts v5 or remove/replace react-scripts) * Only adds NODE_OPTIONS when run on node 18 or later * Performs frontend-code-test on node 18 * Does _not_ run backend_deploy/frontend_deploy with node 18. This can be changed via using cimg/python:3.10-node (versions after 3.10.8-node use node 18 instead of node 16) Node 16 EOL Notice: https://nodejs.org/en/blog/announcements/nodejs16-eol create-react-app --openssl-legacy-provider: facebook/create-react-app#11562 Signed-off-by: Taylor Smock <[email protected]>
|
Kudos, SonarCloud Quality Gate passed!
|
|
We built some node images for this issue while we work to get TM running on a newer version: https://quay.io/repository/hotosm/node?tab=tags |
|
@varun2948 @tsmock - with the node upgrade coming from #5721 merge is this relevant? |
|
Nope. We can close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the following:
Node 16 EOL Notice: https://nodejs.org/en/blog/announcements/nodejs16-eol
create-react-app --openssl-legacy-provider: facebook/create-react-app#11562
This is intended to be a temporary fix for #5767.