Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the /login API call to use JSON instead of urlencoded POST parameters #110

Open
CrsiX opened this issue May 18, 2022 · 1 comment
Labels
improvement There's improvment needed with something

Comments

@CrsiX
Copy link
Member

CrsiX commented May 18, 2022

No description provided.

@CrsiX CrsiX added the improvement There's improvment needed with something label May 18, 2022
@CrsiX
Copy link
Member Author

CrsiX commented Nov 28, 2022

It would be okay if the endpoint accepted both variants, depending on the Content-Type of the request. But dropping the variant using url-encoded arguments is a bad idea for the reason of compatibility with the OAuth workflow currently used for authentication -- this workflow requires url-encoded arguments.
However, it needs to be evaluated how the support for two different request types (depending on Content-Type) can be represented in the automatic API documentation (OpenAPI schema).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement There's improvment needed with something
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant