Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect location for class and violation of frankenstyle naming rules. #113

Open
danmarsden opened this issue Mar 19, 2024 · 0 comments
Open
Labels
enhancement New feature or request mdl-coding-sty All issues related to https://docs.moodle.org/dev/Coding_style mdl-submission-review

Comments

@danmarsden
Copy link

the exceptions class "onlinejudge_exception" is incorrectly located (and named) and so is the "judge_base" class in your judgelib.php file.

also most of the functions in your judgelib.php are incorrectly named, and the judge/sandbox/lib.php also looks wrong too.

for more information see:
https://moodledev.io/general/development/policies/codingstyle/frankenstyle#class-names

Please note that compliance with the frankenstyle naming is a requirement for plugins db approval.

@danmarsden danmarsden added the bug Something isn't working label Mar 19, 2024
@ndrwnaguib ndrwnaguib added enhancement New feature or request mdl-coding-sty All issues related to https://docs.moodle.org/dev/Coding_style and removed bug Something isn't working labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request mdl-coding-sty All issues related to https://docs.moodle.org/dev/Coding_style mdl-submission-review
Projects
None yet
Development

No branches or pull requests

2 participants