Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sshd not parsing PubKeyAcceptedAlgorithms as a list #804

Open
dave-re-imprivata opened this issue Feb 14, 2023 · 4 comments
Open

Sshd not parsing PubKeyAcceptedAlgorithms as a list #804

dave-re-imprivata opened this issue Feb 14, 2023 · 4 comments

Comments

@dave-re-imprivata
Copy link
Contributor

dave-re-imprivata commented Feb 14, 2023

PubKeyAcceptedAlgorithms is seemingly a list, like HostKeyAlgorithms, Ciphers, MACs, etc. The lens doesn't currently support it as such.

Edit to add - in fact, PubkeyAcceptedAlgorithms replaces PubkeyAcceptedKeyTypes, the latter being treated as an alias to PubkeyAcceptedAlgorithms as of OpenSSH 8.5.

This diff seems to add support for it correctly:

--- sshd.aug	2023-02-14 16:17:56.965333293 -0600
+++ dist/sshd.aug	2018-11-30 16:35:49.000000000 -0600
@@ -73,7 +73,7 @@
    let indent = del /[ \t]*/ "  "
 
    let key_re = /[A-Za-z0-9]+/
-         - /MACs|Match|AcceptEnv|Subsystem|Ciphers|(Kex|HostKey|PubkeyAccepted)Algorithms|(Allow|Deny)(Groups|Users)/i
+         - /MACs|Match|AcceptEnv|Subsystem|Ciphers|(Kex|HostKey)Algorithms|(Allow|Deny)(Groups|Users)/i
 
    let comment = Util.comment
    let comment_noindent = Util.comment_noindent
@@ -119,12 +119,10 @@
 
    let hostkeyalgorithms = list /HostKeyAlgorithms/i "HostKeyAlgorithms"
 
-   let pubkeyacceptedalgorithms = list /PubkeyAcceptedAlgorithms/i "PubkeyAcceptedAlgorithms"
-
    let entry = accept_env | allow_groups | allow_users
              | deny_groups | subsystem | deny_users
              | macs | ciphers | kexalgorithms | hostkeyalgorithms
-             | pubkeyacceptedalgorithms | other_entry
+             | other_entry
 
    let condition_entry =
     let value = store  /[^ \t\n=]+/ in
@igalic
Copy link

igalic commented Feb 18, 2023

why not submit this as pull request?

@dave-re-imprivata
Copy link
Contributor Author

why not submit this as pull request?

I intend to - haven't been able to come up for air to do it, yet!

@igalic
Copy link

igalic commented Feb 22, 2023

i know that feeling all too well 💜
no stress!

@dave-re-imprivata
Copy link
Contributor Author

PR submitted 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants