haskell-process-load-complete: handle ghc 9.10 message #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, thanks — merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ghc 9.10 and later can respond to
:loadwith "Failed, unloaded all modules." Unfortunatelyhaskell-process-load-completedoes not recognize this response. This PR fixes this. To simplify and future-proof the code I've adjustedhaskell-process-load-completeto look for the regexesOk, .*$orFailed, .*$. Alternatively, if you'd prefer to narrowly add the "Failed, unloaded all modules." message, you could cherry-pick this commit.This may possibly fix #1642.