Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Allow support for harness.io/pipelines annotations without the keys #130

Open
OrkoHunter opened this issue Jul 15, 2024 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@OrkoHunter
Copy link
Collaborator

🔖 Feature description

Currently the harness.io/pipelines annotations expects an array of key value pairs like this

metadata:
  annotations:
    harness.io/pipelines: |
      ci: ci_pipeline_link
      cd: cd_pipeline_link
      key1: url1

However it should also be possible to skip these keys here. If the keys are missing, then the pipeline name can be used as the keys in the dropdown list.

metadata:
  annotations:
    harness.io/pipelines: |
      ci_pipeline_link
      cd_pipeline_link
      url1

or simply

metadata:
  annotations:
    harness.io/pipelines: pipeline_link

🎤 Context

✌️ Possible Implementation

{Object.keys(harnessPipelineObject).length > 0 ? (
<ListSubheader>Pipelines</ListSubheader>
) : null}
{Object.keys(harnessPipelineObject).map(envId => (
<MenuItem value={harnessPipelineObject[envId]}>{envId}</MenuItem>
))}

@OrkoHunter OrkoHunter added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 15, 2024
@OrkoHunter
Copy link
Collaborator Author

@OrkoHunter
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant