Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add search functionality for use-permission-search and link it to the user profile #1810

Open
wants to merge 6 commits into
base: development
Choose a base branch
from

Conversation

vorleakyek
Copy link
Member

Fixes #1754

What changes did you make and why did you make them ?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b vorleakyek-filtered-permission-1754 development
git pull https://github.com/vorleakyek/VRMS.git filtered-permission-1754

Copy link
Member

@pluto-bell pluto-bell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this issue!

One thing I noticed, it looks like the search/filter is hooked up for "Admins" but not for "Project Leads". Should it be hooked up for "Project Leads" as well?

Screen.Recording.2024-11-18.at.5.19.32.PM.mov

@vorleakyek
Copy link
Member Author

vorleakyek commented Nov 19, 2024

@pluto-bell, Thanks for taking a look! Currently, I have to use the "user" data for the search function to check the link to the user profile. Using the "dummyData" won't work for the link. The search result for project leads is empty because "users" data does not seem to have accessLevel: 'projectLead'. I brought this up in #1808 PR. We probably have to deal with it as part of #1801.

But, changing "users" to "dummyData" in the UserPermissionSearch.jsx should work for the project leads search. Let me know if you have any questions.

// NOTE: Using "users" instead of "dummyData" to check the link to user profile
filteredData = getFilteredData(users, searchText, userType);

@trillium, should I change the "users" to "dummyData" in this PR or it's okay to leave it since we will have to deal with it as part of the next ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create filtered permissions data component
2 participants