Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update question and date picker #1804

Conversation

angela-lee1
Copy link
Member

@angela-lee1 angela-lee1 commented Oct 23, 2024

Fixes #1729

What changes did you make and why did you make them ?

  • We need to update the question text and date picker on the 'Check In As a New User' and 'Create a New Profile' screens to accurately track when members first joined Hack for LA, as the current options are insufficient.
    • Changed the text to "IS THIS YOUR FIRST TIME ATTENDING A HACK FOR LA MEETING?"
    • Changed text to: "WHEN DID YOU FIRST JOIN HACK FOR LA?" in database
    • UPDATE the "year" component of the date picker so that the date displays years ranging from 2013 up to the current year
    • Changes are applied to both routes.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

[image](Screenshot 2024-10-21 at 2 06 24 PM)

Visuals after changes are applied

[image](
!
Screenshot 2024-10-27 at 7 09 44 PM)
)

)

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b angela-lee1-update-question-datepicker-checkin-newuser-create-newprofile development
git pull https://github.com/angela-lee1/VRMS.git update-question-datepicker-checkin-newuser-create-newprofile

@pluto-bell pluto-bell self-requested a review October 25, 2024 00:08
Copy link
Member

@pluto-bell pluto-bell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, good work 👍 Everything is showing up on local host and working as expected, & the additional code looks great.

One thing to point out, the text doesn't seem to need all caps in the file, styling is taking care of it—I believe it's the font-family specifically.

@pluto-bell pluto-bell self-requested a review October 25, 2024 00:33
Copy link
Member

@pluto-bell pluto-bell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am noticing that MUI components didn't seem to be utilized, per the issue #1729:

UPDATE the "year" component of the date picker so that the date displays years ranging from 2013 up to the current year, using MUI components (potentially reference MUI documentation and Stack Overflow to ensure only the year is listed)

@JackHaeg
Copy link
Member

@angela-lee1 As discussed during call, use a single date picker (Month & Year).

@JackHaeg JackHaeg added the time-sensitive should be solved as soon as possible label Oct 29, 2024
@angela-lee1
Copy link
Member Author

angela-lee1 commented Nov 4, 2024

@JackHaeg @trillium Here is the image for using a single date picker. [image](Screenshot 2024-11-04 at 4 30 39 PM)

@JackHaeg
Copy link
Member

JackHaeg commented Nov 4, 2024

This is looking great, @angela-lee1! Thanks for your work on this :)

To any reviewers looking at this PR - please hold off on reviewing / merging this PR until Angela comments that the mobile view is working as expected.

@angela-lee1
Copy link
Member Author

angela-lee1 commented Nov 6, 2024

  • [mobile]

  • [desktop]

@trillium yarn dev see if you can get the same UI. The month is in 3 capitalized letters in DB. Sorry about the package manager. Thank you.

@trillium trillium force-pushed the update-question-datepicker-checkin-newuser-create-newprofile branch from cc0e017 to 3e031fc Compare November 6, 2024 22:04
Copy link
Member

@trillium trillium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Thanks for slogging through this to the end :)

@trillium trillium merged commit c5bc4ee into hackforla:development Nov 6, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
time-sensitive should be solved as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update "Hack Night" Question & Date picker From New User Check In and Create a New Profile
4 participants