-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update question and date picker #1804
update question and date picker #1804
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, good work 👍 Everything is showing up on local host and working as expected, & the additional code looks great.
One thing to point out, the text doesn't seem to need all caps in the file, styling is taking care of it—I believe it's the font-family specifically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am noticing that MUI components didn't seem to be utilized, per the issue #1729:
UPDATE the "year" component of the date picker so that the date displays years ranging from 2013 up to the current year, using MUI components (potentially reference MUI documentation and Stack Overflow to ensure only the year is listed)
@angela-lee1 As discussed during call, use a single date picker (Month & Year). |
This is looking great, @angela-lee1! Thanks for your work on this :) To any reviewers looking at this PR - please hold off on reviewing / merging this PR until Angela comments that the mobile view is working as expected. |
@trillium yarn dev see if you can get the same UI. The month is in 3 capitalized letters in DB. Sorry about the package manager. Thank you. |
cc0e017
to
3e031fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great! Thanks for slogging through this to the end :)
…wuser-create-newprofile
Fixes #1729
What changes did you make and why did you make them ?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
[image]()
Visuals after changes are applied
[image](
!
)
)
)