Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: broken link to issue board in CONTRIBUTING.md #1803

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

pluto-bell
Copy link
Member

What changes did you make and why did you make them ?

  • Changed link to the issue board's Prioritized Backlog because current link was taking me to a 404 page.

Note

  • If there's a different link that is preferred, let me know and I'll happily switch it out.

Screen Captures of Proposed Changes

Screen Capture before changes are applied
broken-issues-link-vrms.mov
Screen Capture after changes are applied
fix-issue-board-link-vrms.mov

Links to test yourself

Current CONTRIBUTING.md — click on the "Prioritized Backlog Column" link
Fixed CONTRIBUTING.md — click on the "Prioritized Backlog Column" link

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b pluto-bell-fix-broken-issues-link development
git pull https://github.com/pluto-bell/VRMS.git fix-broken-issues-link

@vorleakyek
Copy link
Member

@pluto-bell, is there a ticket number that can be linked in the PR comment?

@pluto-bell
Copy link
Member Author

@vorleakyek, I didn't make an issue since the onboarding instructions didn't make mention of creating one, only making a PR:
Screenshot 2024-10-28 at 12 25 29 PM

Reference Issue: #1800

@vorleakyek
Copy link
Member

@pluto-bell, sounds good. I just want to make sure.

@JackHaeg JackHaeg self-requested a review October 29, 2024 00:51
@JackHaeg JackHaeg added the ready for dev lead Add to issue when dev lead needs to take some action label Oct 29, 2024
Copy link
Member

@JackHaeg JackHaeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates, Pluto!

@JackHaeg JackHaeg merged commit 2b520c0 into hackforla:development Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for dev lead Add to issue when dev lead needs to take some action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants