Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Latest Electron Build failing #336

Open
Armaldio opened this issue Dec 3, 2024 · 0 comments
Open

Latest Electron Build failing #336

Armaldio opened this issue Dec 3, 2024 · 0 comments

Comments

@Armaldio
Copy link
Contributor

Armaldio commented Dec 3, 2024

Since the last update, I'm unable to build for latests electron

Following instructions here: https://github.com/greenheartgames/greenworks/blob/master/docs/build-instructions-electron.md
Replaced --dist-url with the correct new headers

HOME=~/.electron-gyp node-gyp rebuild --target=33.0.0 --arch=x64 --dist-url=https://electronjs.org/headers
Log 
gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | linux | x64
gyp info find Python using Python version 3.12.7 found at "/usr/bin/python3"

gyp http GET https://electronjs.org/headers/v33.0.0/node-v33.0.0-headers.tar.gz
gyp http 200 https://artifacts.electronjs.org/headers/v33.0.0/node-v33.0.0-headers.tar.gz?force_headers_dist=1
gyp http GET https://electronjs.org/headers/v33.0.0/SHASUMS256.txt
gyp http 200 https://artifacts.electronjs.org/headers/v33.0.0/SHASUMS256.txt?force_headers_dist=1
gyp info spawn /usr/bin/python3
gyp info spawn args [
gyp info spawn args '/usr/lib/node_modules/node-gyp/gyp/gyp_main.py',
gyp info spawn args 'binding.gyp',
gyp info spawn args '-f',
gyp info spawn args 'make',
gyp info spawn args '-I',
gyp info spawn args '/home/quentin/Projects/greenworks-prebuilds/greenworks/build/config.gypi',
gyp info spawn args '-I',
gyp info spawn args '/usr/lib/node_modules/node-gyp/addon.gypi',
gyp info spawn args '-I',
gyp info spawn args '/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/common.gypi',
gyp info spawn args '-Dlibrary=shared_library',
gyp info spawn args '-Dvisibility=default',
gyp info spawn args '-Dnode_root_dir=/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0',
gyp info spawn args '-Dnode_gyp_dir=/usr/lib/node_modules/node-gyp',
gyp info spawn args '-Dnode_lib_file=/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/<(target_arch)/node.lib',
gyp info spawn args '-Dmodule_root_dir=/home/quentin/Projects/greenworks-prebuilds/greenworks',
gyp info spawn args '-Dnode_engine=v8',
gyp info spawn args '--depth=.',
gyp info spawn args '--no-parallel',
gyp info spawn args '--generator-output',
gyp info spawn args 'build',
gyp info spawn args '-Goutput_dir=.'
gyp info spawn args ]
<string>:130: SyntaxWarning: invalid escape sequence '\$'
gyp info spawn make
gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build' ]
make: Entering directory '/home/quentin/Projects/greenworks-prebuilds/greenworks/build'
  CC(target) Release/obj.target/minizip/deps/zlib/contrib/minizip/ioapi.o
  CC(target) Release/obj.target/minizip/deps/zlib/contrib/minizip/unzip.o
  CC(target) Release/obj.target/minizip/deps/zlib/contrib/minizip/zip.o
../deps/zlib/contrib/minizip/zip.c: In function ‘zip64local_SearchCentralDir’:
../deps/zlib/contrib/minizip/zip.c:521:5: warning: this ‘for’ clause does not guard... [-Wmisleading-indentation]
  521 |     for (i=(int)uReadSize-3; (i--)>0;)
      |     ^~~
../deps/zlib/contrib/minizip/zip.c:529:7: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘for’
  529 |       if (uPosFound!=0)
      |       ^~
rm -f Release/obj.target/deps/zlib/minizip.a Release/obj.target/deps/zlib/minizip.a.ar-file-list; mkdir -p `dirname Release/obj.target/deps/zlib/minizip.a`
ar crs Release/obj.target/deps/zlib/minizip.a @Release/obj.target/deps/zlib/minizip.a.ar-file-list
  COPY Release/minizip.a
  CC(target) Release/obj.target/zlib/deps/zlib/adler32.o
  CC(target) Release/obj.target/zlib/deps/zlib/compress.o
  CC(target) Release/obj.target/zlib/deps/zlib/crc32.o
  CC(target) Release/obj.target/zlib/deps/zlib/deflate.o
  CC(target) Release/obj.target/zlib/deps/zlib/gzclose.o
  CC(target) Release/obj.target/zlib/deps/zlib/gzlib.o
  CC(target) Release/obj.target/zlib/deps/zlib/gzread.o
  CC(target) Release/obj.target/zlib/deps/zlib/gzwrite.o
  CC(target) Release/obj.target/zlib/deps/zlib/infback.o
../deps/zlib/infback.c: In function ‘MOZ_Z_inflateBack’:
../deps/zlib/infback.c:471:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  471 |             state->mode = LEN;
      |             ~~~~~~~~~~~~^~~~~
../deps/zlib/infback.c:473:9: note: here
  473 |         case LEN:
      |         ^~~~
  CC(target) Release/obj.target/zlib/deps/zlib/inffast.o
  CC(target) Release/obj.target/zlib/deps/zlib/inflate.o
../deps/zlib/inflate.c: In function ‘MOZ_Z_inflateMark’:
../deps/zlib/inflate.c:1475:61: warning: left shift of negative value [-Wshift-negative-value]
 1475 |     if (strm == Z_NULL || strm->state == Z_NULL) return -1L << 16;
      |                                                             ^~
../deps/zlib/inflate.c: In function ‘MOZ_Z_inflate’:
../deps/zlib/inflate.c:704:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  704 |             state->mode = EXLEN;
      |             ~~~~~~~~~~~~^~~~~~~
../deps/zlib/inflate.c:705:9: note: here
  705 |         case EXLEN:
      |         ^~~~
../deps/zlib/inflate.c:716:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  716 |             state->mode = EXTRA;
      |             ~~~~~~~~~~~~^~~~~~~
../deps/zlib/inflate.c:717:9: note: here
  717 |         case EXTRA:
      |         ^~~~
../deps/zlib/inflate.c:738:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  738 |             state->mode = NAME;
      |             ~~~~~~~~~~~~^~~~~~
../deps/zlib/inflate.c:739:9: note: here
  739 |         case NAME:
      |         ^~~~
../deps/zlib/inflate.c:759:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  759 |             state->mode = COMMENT;
      |             ~~~~~~~~~~~~^~~~~~~~~
../deps/zlib/inflate.c:760:9: note: here
  760 |         case COMMENT:
      |         ^~~~
../deps/zlib/inflate.c:779:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  779 |             state->mode = HCRC;
      |             ~~~~~~~~~~~~^~~~~~
../deps/zlib/inflate.c:780:9: note: here
  780 |         case HCRC:
      |         ^~~~
../deps/zlib/inflate.c:802:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  802 |             state->mode = DICT;
      |             ~~~~~~~~~~~~^~~~~~
../deps/zlib/inflate.c:803:9: note: here
  803 |         case DICT:
      |         ^~~~
../deps/zlib/inflate.c:809:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  809 |             state->mode = TYPE;
      |             ~~~~~~~~~~~~^~~~~~
../deps/zlib/inflate.c:810:9: note: here
  810 |         case TYPE:
      |         ^~~~
../deps/zlib/inflate.c:811:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
  811 |             if (flush == Z_BLOCK || flush == Z_TREES) goto inf_leave;
      |                ^
../deps/zlib/inflate.c:812:9: note: here
  812 |         case TYPEDO:
      |         ^~~~
../deps/zlib/inflate.c:861:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
  861 |             if (flush == Z_TREES) goto inf_leave;
      |                ^
../deps/zlib/inflate.c:862:9: note: here
  862 |         case COPY_:
      |         ^~~~
../deps/zlib/inflate.c:863:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
  863 |             state->mode = COPY;
      |             ~~~~~~~~~~~~^~~~~~
../deps/zlib/inflate.c:864:9: note: here
  864 |         case COPY:
      |         ^~~~
../deps/zlib/inflate.c:1003:16: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1003 |             if (flush == Z_TREES) goto inf_leave;
      |                ^
../deps/zlib/inflate.c:1004:9: note: here
 1004 |         case LEN_:
      |         ^~~~
../deps/zlib/inflate.c:1005:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1005 |             state->mode = LEN;
      |             ~~~~~~~~~~~~^~~~~
../deps/zlib/inflate.c:1006:9: note: here
 1006 |         case LEN:
      |         ^~~~
../deps/zlib/inflate.c:1054:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1054 |             state->mode = LENEXT;
      |             ~~~~~~~~~~~~^~~~~~~~
../deps/zlib/inflate.c:1055:9: note: here
 1055 |         case LENEXT:
      |         ^~~~
../deps/zlib/inflate.c:1064:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1064 |             state->mode = DIST;
      |             ~~~~~~~~~~~~^~~~~~
../deps/zlib/inflate.c:1065:9: note: here
 1065 |         case DIST:
      |         ^~~~
../deps/zlib/inflate.c:1091:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1091 |             state->mode = DISTEXT;
      |             ~~~~~~~~~~~~^~~~~~~~~
../deps/zlib/inflate.c:1092:9: note: here
 1092 |         case DISTEXT:
      |         ^~~~
../deps/zlib/inflate.c:1107:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1107 |             state->mode = MATCH;
      |             ~~~~~~~~~~~~^~~~~~~
../deps/zlib/inflate.c:1108:9: note: here
 1108 |         case MATCH:
      |         ^~~~
../deps/zlib/inflate.c:1182:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1182 |             state->mode = LENGTH;
      |             ~~~~~~~~~~~~^~~~~~~~
../deps/zlib/inflate.c:1183:9: note: here
 1183 |         case LENGTH:
      |         ^~~~
../deps/zlib/inflate.c:1195:25: warning: this statement may fall through [-Wimplicit-fallthrough=]
 1195 |             state->mode = DONE;
      |             ~~~~~~~~~~~~^~~~~~
../deps/zlib/inflate.c:1196:9: note: here
 1196 |         case DONE:
      |         ^~~~
  CC(target) Release/obj.target/zlib/deps/zlib/inftrees.o
  CC(target) Release/obj.target/zlib/deps/zlib/trees.o
  CC(target) Release/obj.target/zlib/deps/zlib/uncompr.o
  CC(target) Release/obj.target/zlib/deps/zlib/zutil.o
rm -f Release/obj.target/deps/zlib/chrome_zlib.a Release/obj.target/deps/zlib/chrome_zlib.a.ar-file-list; mkdir -p `dirname Release/obj.target/deps/zlib/chrome_zlib.a`
ar crs Release/obj.target/deps/zlib/chrome_zlib.a @Release/obj.target/deps/zlib/chrome_zlib.a.ar-file-list
  COPY Release/chrome_zlib.a
  CXX(target) Release/obj.target/greenworks-linux64/src/api/greenworks_api_utils.o
In file included from ../node_modules/.pnpm/[email protected]/node_modules/nan/nan.h:3045,
                 from ../src/api/greenworks_api_utils.cc:7:
../node_modules/.pnpm/[email protected]/node_modules/nan/nan_scriptorigin.h: In constructor ‘Nan::ScriptOrigin::ScriptOrigin(v8::Local<v8::Value>)’:
../node_modules/.pnpm/[email protected]/node_modules/nan/nan_scriptorigin.h:36:55: error: no matching function for call to ‘v8::ScriptOrigin::ScriptOrigin(v8::Isolate*, v8::Local<v8::Value>&)’
   36 |       v8::ScriptOrigin(v8::Isolate::GetCurrent(), name) {}
      |                                                       ^
In file included from /home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-script.h:20,
                 from /home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-debug.h:10,
                 from /home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-isolate.h:19,
                 from /home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-snapshot.h:9,
                 from /home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-context.h:15,
                 from /home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8.h:26,
                 from /home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/node.h:79,
                 from ../node_modules/.pnpm/[email protected]/node_modules/nan/nan.h:62:
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:64:13: note: candidate: ‘v8::ScriptOrigin::ScriptOrigin(v8::Local<v8::Value>, int, int, bool, int, v8::Local<v8::Value>, bool, bool, bool, v8::Local<v8::Data>)’
   64 |   V8_INLINE ScriptOrigin(Local<Value> resource_name,
      |             ^~~~~~~~~~~~
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:64:39: note:   no known conversion for argument 1 from ‘v8::Isolate*’ to ‘v8::Local<v8::Value>’
   64 |   V8_INLINE ScriptOrigin(Local<Value> resource_name,
      |                          ~~~~~~~~~~~~~^~~~~~~~~~~~~
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:62:17: note: candidate: ‘constexpr v8::ScriptOrigin::ScriptOrigin(const v8::ScriptOrigin&)’
   62 | class V8_EXPORT ScriptOrigin {
      |                 ^~~~~~~~~~~~
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:62:17: note:   candidate expects 1 argument, 2 provided
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:62:17: note: candidate: ‘constexpr v8::ScriptOrigin::ScriptOrigin(v8::ScriptOrigin&&)’
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:62:17: note:   candidate expects 1 argument, 2 provided
../node_modules/.pnpm/[email protected]/node_modules/nan/nan_scriptorigin.h: In constructor ‘Nan::ScriptOrigin::ScriptOrigin(v8::Local<v8::Value>, v8::Local<v8::Integer>)’:
../node_modules/.pnpm/[email protected]/node_modules/nan/nan_scriptorigin.h:42:52: error: no matching function for call to ‘v8::ScriptOrigin::ScriptOrigin(v8::Isolate*, v8::Local<v8::Value>&, int)’
   42 |                    , To<int32_t>(line).FromMaybe(0)) {}
      |                                                    ^
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:64:13: note: candidate: ‘v8::ScriptOrigin::ScriptOrigin(v8::Local<v8::Value>, int, int, bool, int, v8::Local<v8::Value>, bool, bool, bool, v8::Local<v8::Data>)’
   64 |   V8_INLINE ScriptOrigin(Local<Value> resource_name,
      |             ^~~~~~~~~~~~
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:64:39: note:   no known conversion for argument 1 from ‘v8::Isolate*’ to ‘v8::Local<v8::Value>’
   64 |   V8_INLINE ScriptOrigin(Local<Value> resource_name,
      |                          ~~~~~~~~~~~~~^~~~~~~~~~~~~
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:62:17: note: candidate: ‘constexpr v8::ScriptOrigin::ScriptOrigin(const v8::ScriptOrigin&)’
   62 | class V8_EXPORT ScriptOrigin {
      |                 ^~~~~~~~~~~~
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:62:17: note:   candidate expects 1 argument, 3 provided
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:62:17: note: candidate: ‘constexpr v8::ScriptOrigin::ScriptOrigin(v8::ScriptOrigin&&)’
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:62:17: note:   candidate expects 1 argument, 3 provided
../node_modules/.pnpm/[email protected]/node_modules/nan/nan_scriptorigin.h: In constructor ‘Nan::ScriptOrigin::ScriptOrigin(v8::Local<v8::Value>, v8::Local<v8::Integer>, v8::Local<v8::Integer>)’:
../node_modules/.pnpm/[email protected]/node_modules/nan/nan_scriptorigin.h:50:54: error: no matching function for call to ‘v8::ScriptOrigin::ScriptOrigin(v8::Isolate*, v8::Local<v8::Value>&, int, int)’
   50 |                    , To<int32_t>(column).FromMaybe(0)) {}
      |                                                      ^
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:64:13: note: candidate: ‘v8::ScriptOrigin::ScriptOrigin(v8::Local<v8::Value>, int, int, bool, int, v8::Local<v8::Value>, bool, bool, bool, v8::Local<v8::Data>)’
   64 |   V8_INLINE ScriptOrigin(Local<Value> resource_name,
      |             ^~~~~~~~~~~~
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:64:39: note:   no known conversion for argument 1 from ‘v8::Isolate*’ to ‘v8::Local<v8::Value>’
   64 |   V8_INLINE ScriptOrigin(Local<Value> resource_name,
      |                          ~~~~~~~~~~~~~^~~~~~~~~~~~~
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:62:17: note: candidate: ‘constexpr v8::ScriptOrigin::ScriptOrigin(const v8::ScriptOrigin&)’
   62 | class V8_EXPORT ScriptOrigin {
      |                 ^~~~~~~~~~~~
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:62:17: note:   candidate expects 1 argument, 4 provided
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:62:17: note: candidate: ‘constexpr v8::ScriptOrigin::ScriptOrigin(v8::ScriptOrigin&&)’
/home/quentin/.electron-gyp/.cache/node-gyp/33.0.0/include/node/v8-message.h:62:17: note:   candidate expects 1 argument, 4 provided
make: *** [greenworks-linux64.target.mk:159: Release/obj.target/greenworks-linux64/src/api/greenworks_api_utils.o] Error 1
make: Leaving directory '/home/quentin/Projects/greenworks-prebuilds/greenworks/build'
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack at ChildProcess.<anonymous> (/usr/lib/node_modules/node-gyp/lib/build.js:216:23)
gyp ERR! System Linux 6.10.14-1-MANJARO
gyp ERR! command "/home/quentin/.local/share/mise/installs/node/18.20.5/bin/node" "/usr/bin/node-gyp" "rebuild" "--target=33.0.0" "--arch=x64" "--dist-url=https://electronjs.org/headers"
gyp ERR! cwd /home/quentin/Projects/greenworks-prebuilds/greenworks
gyp ERR! node -v v18.20.5
gyp ERR! node-gyp -v v10.2.0
gyp ERR! not ok

Specific error:

../node_modules/.pnpm/[email protected]/node_modules/nan/nan_scriptorigin.h:42:52: error: no matching function for call to ‘v8::ScriptOrigin::ScriptOrigin(v8::Isolate*, v8::Local<v8::Value>&, int)’
   42 |                    , To<int32_t>(line).FromMaybe(0)) {}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Armaldio