You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think you should add more information in comments where issues are thrown. I will set an example:
The line 58 triggers a rule, not related with the rule the file is supposed to test but, well, it is here. I think you should indicate in this case that an issue should be found at that line.
On the line 62, on the same idea, I think you should indicate in the comment the rule that we expect here, to be sure it is the good one that is detected.
Regards.
The text was updated successfully, but these errors were encountered:
jhertout
changed the title
be more precise in comment "Non Compliant"
Be more precise in comment "Non Compliant"
Mar 13, 2023
First, indeed, you're right : I have to be more precise on the comment in the good line. I will do that.
Secondly, as you see, others issues are raised. I only copied the files already presents in resources of unit tests of original project. And, they already had some existing problems. I already corrected some previous easy issues but still existing ones aren't so simple to correct without refactoring all the file. I wanted to create quickly this project.
OK, I think in some cases you will not have the choice and other issues will be raised in files that are tested a specific issue. We have this "problem" in the Android test project. We just add a comment as for other issues.
Hi,
I think you should add more information in comments where issues are thrown. I will set an example:
The line 58 triggers a rule, not related with the rule the file is supposed to test but, well, it is here. I think you should indicate in this case that an issue should be found at that line.
On the line 62, on the same idea, I think you should indicate in the comment the rule that we expect here, to be sure it is the good one that is detected.
Regards.
The text was updated successfully, but these errors were encountered: