Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Munge special characters in env variables #8

Closed
wants to merge 1 commit into from
Closed

Munge special characters in env variables #8

wants to merge 1 commit into from

Conversation

lenaschoenburg
Copy link

Fixes #7.

The style I've chosen here leads to very verbose variable names but I wanted to make sure that there isn't a chance for ambiguous names. Let me know what you think, I'm happy to make changes.

@lenaschoenburg
Copy link
Author

@alexander-yakushev ping?

@alexander-yakushev
Copy link
Contributor

Sorry for the delay.

The problem with this solution is that it contains __ in the munged replacements, but we already use __ as a separator in nested options.

I'll probably also drop the support for the following characters:

  • ' (not idiomatic in keywords)
  • _ (not idiomatic in keywords)
  • . (is already used as a separator in CLI arguments, would be confusing)
  • / (used for namespacing keywords, doesn't fit here well)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Questionmark is not a valid character in environment variables
2 participants
@lenaschoenburg @alexander-yakushev