Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questionmark is not a valid character in environment variables #7

Open
lenaschoenburg opened this issue Jul 12, 2017 · 3 comments
Open

Comments

@lenaschoenburg
Copy link

Question marks are not allowed in environment variables but are valid keywords in clojure. We should escape question mark to something (maybe _Q_) and use that as the variable name.

@alexander-yakushev
Copy link
Contributor

This is a good point. However, if we are to go this way I prefer making a comprehensive munging/unmunging suite for each config source (env, cli opts, etc.), not just limit ourselves to question mark. What do you think?

@lenaschoenburg
Copy link
Author

Agreed. I wonder if the clojure source code contains some code for this already? For munging function names in exceptions etc.

@alexander-yakushev
Copy link
Contributor

There is munging, but it is for making Clojure literals Java (JVM) friendly. We'll need custom munging/unmunging for our purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants