Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Ability to add data-readers when reading a configuration file #12

Open
neuromantik33 opened this issue Dec 11, 2018 · 1 comment

Comments

@neuromantik33
Copy link
Contributor

Hello,
I have a perhaps rare but not unheard of usecase where I need to read a configuration file with custom reader macros (like integrant's ig/ref). Therefore I've provided a simple patch which breaks the api somewhat (the depracted quit-on-error? arity) @ here.

Can you tell me if this goes against the philosophy of omniconf as I use the latter as a centralized configuration system-of-record which contains many other types of configurations, some of which make use of reader macros.

Thanks for any feedback,

Nicolas

@alexander-yakushev
Copy link
Contributor

Hi Nicolas,

I think there is no problem with Omniconf supporting such feature. I would accept this as a PR if you don't mind implementing it non-breakingly, e.g. by introducing a dynamic variable, maybe? You could than mention it in the dosctring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants