-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Offer click to allow once replacements for certain content #1899
Comments
For Disqus, import the following URL itself (experimental) into the custom filter list in the "3rd-party filters" pane: |
it would be cool if you could decide in the filter wether something is completely removed or replaced with a placeholder like with flash that can be activated when needed. |
For Flash applets, just use the browser's own click-to-play feature. |
@gorhill it is just an analogy to flash, not about flash itself. |
@gorhill I've been noticing a trend recently of a lot of websites moving away from Disqus for comments sections. (Anecdotally I have seen the shift go sometimes towards live fyre but MOSTLY towards facebook comment sections.) I could see a 'click to allow' functionality being very useful for things such as Brightcove's media player, facebook comments, embedded youtube videos, etc. This is not a request of you per se, but is it possible for anyone to create a filter list with the same type of functionality as your 'Disqus click to load' filterlist for other external web components or would that require modifying uBlock Origin? e.g. In order for it to work beyond Disqus, would we need to add in our own special injected scripts within uBlock for the same Disqus functionality to work with any other external request? I personally love the way the 'click to load for Disqus' was implemented and use it very frequently but I imagine it is a pretty hidden option / not used by very many users unless they are the type to go digging through the issue tracker here. It would be awesome if this is possible for other sites already and is just an issue of starting a 'click to load' filterlist for common third party web elements. This would allow filterlist maintainers to expand on your initial thought and start using it for other external requests. Again, this is not a request for you to develop this, just wondering if it is possible with how uBlock is currently setup for anyone to come up with filters to emulate the 'click to load' functionality of Disqus for other sites. Cheers! |
As per AMO reviewer: > We will need you to remove the remote scripts in > > web_accessible_resources\disqus_embed.js - line 48 > web_accessible_resources\disqus_forums_embed.js - line 44 Related issue: - #1899
Additionally, as a requirement to support click-to-load feature, redirected resources will from now on no longer be collapsed. Related issues: - #2688 - #3619 - #1899 This new feature should considered in its draft stage and it needs to be fine-tuned as per feedback. Important: Only embedded frames can be converted into click-to-load widgets, as only these can be properly shieded from access by page content. Examples of usage: ||youtube.com/embed/$3p,frame,redirect=clicktoload ||scribd.com/embeds/$3p,frame,redirect=clicktoload ||player.vimeo.com/video/$3p,frame,redirect=clicktoload
Some pages implement Widgets for comments , videos or music, which is at first a tracking problem as it requests data from a thirdparty domain.
Sometimes you want to participate in the discussion though or watch the video.
It would be cool to have a "allow once and reload" button instead of the original content.
Disquus for example could need such a click-to-play implementation.
The text was updated successfully, but these errors were encountered: