Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

README.md Improvements #1448

Closed
wants to merge 5 commits into from
Closed

README.md Improvements #1448

wants to merge 5 commits into from

Conversation

gdbelvin
Copy link
Contributor

@gdbelvin gdbelvin commented Feb 5, 2020

Fixes #1394 - Show how to fetch the public keys the server is showing for the default directory.
Fixes #1207 - Explain directories
Fixes #1390 - Correct the download instructions for the KT client for Go Modules.
Fixes #1392 - Use a real public key in the example

@gdbelvin gdbelvin requested a review from a team as a code owner February 5, 2020 19:40
@gdbelvin gdbelvin removed the request for review from mhutchinson February 5, 2020 19:40
@codecov
Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #1448 into master will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1448      +/-   ##
==========================================
- Coverage   66.56%   66.39%   -0.18%     
==========================================
  Files          54       54              
  Lines        4026     4026              
==========================================
- Hits         2680     2673       -7     
- Misses        957      961       +4     
- Partials      389      392       +3
Impacted Files Coverage Δ
core/sequencer/server.go 73.61% <0%> (-1.31%) ⬇️
core/integration/client_tests.go 84.54% <0%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9b296f...b7cff95. Read the comment docs.

@gdbelvin gdbelvin changed the title GO111MODULE install directions README.md Improvements Feb 8, 2020
@gdbelvin gdbelvin force-pushed the readme branch 3 times, most recently from fc80d2e to 6c99f58 Compare February 8, 2020 14:13
@Mercurrent
Copy link

Are you still working on this one, Gary?

The current install instructions fall back to non-module mode non-module
mode and result in incorrect dependencies.

Fixes google#1390
@gdbelvin
Copy link
Contributor Author

I'm going to split this PR into it's separate components for ease of review

@gdbelvin gdbelvin closed this Feb 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
3 participants