You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Per the protobuf encoding guide, "Serialization order is an implementation detail and the details of any particular implementation may change in the future".
We rely on signatures over serialized protobufs in the google.keytransparency.v1.SignedEntry proto. There's probably other places as well, that's just the first one that come to mind. It happens to work because the protobuf implementation we use has a stable serialization order, but that shouldn't be relied on.
The text was updated successfully, but these errors were encountered:
In particular, we compare serialized protos in the replay detection here. A new mutation with the same Entry but a different serialization wouldn't be caught by that check.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Per the protobuf encoding guide, "Serialization order is an implementation detail and the details of any particular implementation may change in the future".
We rely on signatures over serialized protobufs in the
google.keytransparency.v1.SignedEntry
proto. There's probably other places as well, that's just the first one that come to mind. It happens to work because the protobuf implementation we use has a stable serialization order, but that shouldn't be relied on.The text was updated successfully, but these errors were encountered: