[docker-compose] Overloaded|Redundant port mappings

[DazWilkin]

The docker-compose file overloads port mappings:

• log-server exposes 8091 and 8090 to the host
• log-signer exposes 8091 too
• map-server exposes 8091 and 8090 too

Recommend
These ports should be distinct on the host. If needed (see #1200), perhaps:

• log-server exposes 8091:8091 and 8090:8090
• log-signer exposes 8093:8091 and 8092:8090
• map-server exposes 8095:8091 and 8094:8094

and:

• server exposes 8081 and 8080 (although this is mapped to the host's 443)
• sequencer exposes 8081 and 8080

Recommend
These ports should be distinct on the host. If these 8081s are not needed outside of the services, they may be removed:

• server exposes 8081:8081 and (unchanged) 443:8080
• sequencer exposes 8083:8081 and (perhaps) 8082:8080

NB although server maps its 8080 to 443 leaving 8080 available on the host, for consistency it may be preferable to explicitly map 8080 to 8082 for sequencer

The inter-service mappings are fine, e.g.:

• server:8081
• sequencer:8081

Recommend
Use server:8081 and sequencer:8081 for the healthchecks rather than exposing the ports to then using localhost:8081; unless these ports are then needed outside of the services, these ports may be removed from the host mapping. If these ports are needed outside of the services, they should be mapped apart perhaps 8081:8081 for one service and 8083:8081 for the other.

keytransparency/docker-compose.yml

Line 61 in 5ac39fe

- "8091"

keytransparency/docker-compose.yml

Line 86 in 5ac39fe

- "8091"

keytransparency/docker-compose.yml

Line 108 in 5ac39fe

- "8091"