Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safe about issue: a wrong password login will effect a correct user to pull images #21224

Open
mengjingji opened this issue Nov 21, 2024 · 6 comments
Labels
Won't Fix The cost of fixing this is not justified.

Comments

@mengjingji
Copy link

Repeat it in these steps:

Using a correct account A to pull images continuously in a loop (on one computer).
Attempting to log in to account A with a wrong password continuously in a loop (on another computer).
then ,we'll see , the step 1 is pulling images can be effected , will not work okay( not ofen ,but some times will error).

We have verified that this issue exists in versions 2.7.x, 2.8.x, and 2.12.x.

@stonezdj
Copy link
Contributor

For security reason, every failed login result in 1.5 second freeze time, it is an expected behaviour.

@mengjingji
Copy link
Author

Our harbor server has been attacked with this method, and we could not deploy apps on docker any more, because of pulling images always failed.

@mengjingji
Copy link
Author

If the attacker keeps requesting with the wrong password in this way constantly and continuously, then the normal user of this account will not be able to pull the image, resulting in the inability to deploy the application.

@wy65701436 wy65701436 added the Won't Fix The cost of fixing this is not justified. label Nov 25, 2024
@stonezdj
Copy link
Contributor

You can select another username to do the pull operation. or check the core.log to find out the failed login's IP and terminate the application, maybe CI/CD-related logins.

@mengjingji
Copy link
Author

Isn't this rather infeasible? By using an incorrect password, one can attack a Harbor server, forcing them to abandon this account and use another one to work. Is this considered normal operation?

@mengjingji
Copy link
Author

@wy65701436

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Won't Fix The cost of fixing this is not justified.
Projects
None yet
Development

No branches or pull requests

3 participants