fix: use a sync.Map to prevent "concurrent map read and map write" fa… #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tal error when using "output: prefixed"
trulede
reviewed
Nov 18, 2024
| @@ -85,11 +86,11 @@ func (pw *prefixWriter) writeLine(line string) error { | |||
| line += "\n" | |||
| } | |||
|
|
|||
| idx, ok := pw.prefixed.seen[pw.prefix] | |||
| idx, ok := pw.prefixed.seen.Load(pw.prefix) | |||
There was a problem hiding this comment.
Perhaps LoadOrStore() is better than Load() and then Store()?
alexandear
reviewed
Nov 21, 2024
|
|
||
| "github.com/go-task/task/v3/internal/logger" | ||
| "github.com/go-task/task/v3/internal/templater" | ||
| ) | ||
|
|
||
| type Prefixed struct { | ||
| logger *logger.Logger | ||
| seen map[string]uint | ||
| seen *sync.Map |
There was a problem hiding this comment.
Can we simply use a mutex for protecting the seen map? It's actively used in this project: 1, 2.
Suggested change
| seen *sync.Map | |
| muSeen sync.Mutex | |
| seen map[string]uint |
Additionally, sync.Map has drawbacks and rare use cases. See https://victoriametrics.com/blog/go-sync-map/
alexandear
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Perhaps we need to add a test case to ensure that this PR fixes an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tal error when using "output: prefixed"
fixes #1922