Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Langchain Cookbook Part 1: The VectorStore object not used in the VectorStores section #32

Open
SwamiKannan opened this issue May 28, 2023 · 0 comments

Comments

@SwamiKannan
Copy link

SwamiKannan commented May 28, 2023

Thanks for the cookbook. Pretty insightful.

In the section for VectorStores (under Indexes), the embeddings of the text are created using
embeddings.embed_documents()
but the vectorstore (FAISS) class is imported but not used as:
db = FAISS.from_documents(texts, embeddings).

Maybe the section should include creation of the vectorstore and its usage

@SwamiKannan SwamiKannan changed the title Langchain Cookbook Part 1: The VectorStore object not used in the VectorStores module Langchain Cookbook Part 1: The VectorStore object not used in the VectorStores section May 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant