Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve OIDC provider JWT retrieval documentation #35340

Open
1 task done
NeoCat opened this issue Nov 19, 2024 · 2 comments · May be fixed by #35341
Open
1 task done

Improve OIDC provider JWT retrieval documentation #35340

NeoCat opened this issue Nov 19, 2024 · 2 comments · May be fixed by #35341
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team

Comments

@NeoCat
Copy link

NeoCat commented Nov 19, 2024

Code of Conduct

What article on docs.github.com is affected?

Requesting the JWT using environment variables

What part(s) of the article would you like to see updated?

The current documentation for manually requesting a JSON Web Token (JWT) from the GitHub OIDC provider has several issues:

  1. The name of environment variable in the script is not valid ( ACTIONS_RUNTIME_TOKEN must be ACTIONS_ID_TOKEN_REQUEST_TOKEN )
  2. The whole node script step is redundant.
  3. jq availability is checked after it is actually used.
  4. Printing tokens / signature to logs has potential security risks and is not useful.

Additional information

No response

@NeoCat NeoCat added the content This issue or pull request belongs to the Docs Content team label Nov 19, 2024
Copy link

welcome bot commented Nov 19, 2024

Thanks for opening this issue. A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 19, 2024
@NeoCat NeoCat linked a pull request Nov 19, 2024 that will close this issue
2 tasks
@nguyenalex836 nguyenalex836 added actions This issue or pull request should be reviewed by the docs actions team and removed triage Do not begin working on this issue until triaged by the team labels Nov 19, 2024
@nguyenalex836
Copy link
Contributor

@NeoCat Thank you for opening an issue and linking it to your PR! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants