Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A3-1-5: Queries follow interpretation of rational and examples that communicate incorrect intentions #481

Open
rvermeulen opened this issue Jan 9, 2024 · 0 comments · May be fixed by #610
Open

A3-1-5: Queries follow interpretation of rational and examples that communicate incorrect intentions #481

rvermeulen opened this issue Jan 9, 2024 · 0 comments · May be fixed by #610
Assignees
@lcartey
Labels
Difficulty-Medium A false positive or false negative report which is expected to take 1-5 days effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-High Standard-AUTOSAR user-report Issue reported by an end user of CodeQL Coding Standards

Comments

@rvermeulen
Copy link
Collaborator

rvermeulen commented Jan 9, 2024 •
edited
Loading

Affected rules

  • cpp/autosar/non-trivial-non-template-function-defined-inside-class-definition
  • cpp/autosar/trivial-or-template-function-defined-outside-class-definition

Description

See discussion for the two interpretations and the intend of MISRA.

This requires removing of trivial-or-template-function-defined-outside-class-definition and solely look at the function definitions that are part of a class definition and ensure they satisfies the conditions set forth in the rule.
@rvermeulen rvermeulen added Difficulty-Medium A false positive or false negative report which is expected to take 1-5 days effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-High labels Jan 9, 2024
@rvermeulen rvermeulen changed the title A3-1-5: Query follows interpretation of rational and examples that communicate incorrect intentions A3-1-5: Queries follow interpretation of rational and examples that communicate incorrect intentions Jan 9, 2024
@lcartey lcartey self-assigned this Jan 14, 2024
@knewbury01 knewbury01 mentioned this issue Jan 31, 2024
Open
@rvermeulen rvermeulen mentioned this issue Feb 20, 2024
Closed
@lcartey lcartey added the user-report Issue reported by an end user of CodeQL Coding Standards label Feb 21, 2024
@lcartey lcartey moved this from Assigned to In Progress in Coding Standards Public Development Board Jun 3, 2024
@lcartey lcartey moved this from In Progress to Ready for review in Coding Standards Public Development Board Jun 3, 2024
@lcartey lcartey linked a pull request Jun 3, 2024 that will close this issue
Open
30 tasks
@lcartey lcartey linked a pull request Jul 24, 2024 that will close this issue
A3-1-5: Remove extraneous cases and handle template instantiations #610
Open
30 tasks
@lcartey lcartey moved this from Ready for review to Reviewed in Coding Standards Public Development Board Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lcartey lcartey

Labels
Difficulty-Medium A false positive or false negative report which is expected to take 1-5 days effort to address false positive/false negative An issue related to observed false positives or false negatives. Impact-High Standard-AUTOSAR user-report Issue reported by an end user of CodeQL Coding Standards
Projects
Coding Standards Public Development Board
Status: Reviewed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

A3-1-5: Remove extraneous cases and handle template instantiations github/codeql-coding-standards
3 participants
@rvermeulen @MichaelRFairhurst @lcartey