Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Json.ISerializer having AllowNullLiteral causes friction with null-checking enabled #630

Open
johnnyggalt opened this issue Nov 19, 2024 · 1 comment
Open

Json.ISerializer having AllowNullLiteral causes friction with null-checking enabled #630

johnnyggalt opened this issue Nov 19, 2024 · 1 comment

Comments

@johnnyggalt
Copy link

This is more an observation and question than anything else...

When migrating a Giraffe-based project from .NET 8 to 9 with null-checking enabled, I ran into some pain that basically boiled down to Json.ISerializer having AllowNullLiteral applied to it. When I grab the latest Giraffe code and remove that attribute, everything still compiles, so I'm wondering why it even has it and whether it could be removed.
@nojaf
Copy link
Contributor

nojaf commented Nov 20, 2024

Hello, I believe @dustinmoris added that attribute years ago.
Dustin do you think this still holds or can we remove it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nojaf @johnnyggalt