Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default onPageNotFound priority should be -1 or less. #30

Open
Flamenco opened this issue Feb 18, 2018 · 2 comments
Open

Default onPageNotFound priority should be -1 or less. #30

Flamenco opened this issue Feb 18, 2018 · 2 comments

Comments

@Flamenco
Copy link

Default onPageNotFound priority should be -1 or less.

This will allow other plugins to set the priority to 0 on onPageNotFound and still be called when they are loaded after the default fallback of this plugin.
@Flamenco Flamenco mentioned this issue Feb 18, 2018
Closed
@rhukster
Copy link
Member

rhukster commented Mar 9, 2018

if you can provide me a PR, I can test it. cheers.

@Flamenco
Copy link
Author

#31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Flamenco @rhukster