Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update php to version 8.1 #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samuelstein
Copy link

@samuelstein samuelstein commented Apr 25, 2023

php 7.4 support is end of life. therefore update php to old stable

@Pumpapa
Copy link

Pumpapa commented Sep 25, 2023

Wholehearted agree that Grav should bump to PHP 8 -- quite a number of skeletons require php 8, so they can fail using docker-grav.
I tried @samuelstein's dockerfile, but that failed with compiler errors

@samuelstein
Copy link
Author

Worked on my machine ☺️.
Can you please provide the error?

@Pumpapa
Copy link

Pumpapa commented Sep 26, 2023

I'm sorry, maybe I shouldn't have spoken. I compiled on a small Pop OS (Ubuntu) server, which isn't an ideal environment. At the time, I made two screenshots that may contain useful information for you. But sadly I am no longer able to use that machine, so I can't repeat the experiment. Sorry again.

Screenshot from 2023-09-25 12-53-02
Screenshot from 2023-09-25 12-53-36

@samuelstein
Copy link
Author

samuelstein commented Apr 23, 2024

@Pumpapa could you please give it a try again? I updated the image.

@YamiDoesDev
Copy link

@Pumpapa could you please give it a try again? I updated the image.

Tried it on my machine as well. Didn't notice any problems so far. Thanks for the edit, as I needed php-something >= 8.1 to update my plugins.
I just wonder, if this repository is still maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants