Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple if pyramids #3

Open
deltabeard opened this issue May 16, 2017 · 2 comments
Open

Multiple if pyramids #3

deltabeard opened this issue May 16, 2017 · 2 comments

Comments

@deltabeard
Copy link

deltabeard commented May 16, 2017

There are multiple if pyramids in your code, such as line 75. Use your if statements to check if the statement is false rather than true. That way you won't need to wrap all your program logic in ifs.

Edit: It looks like pr #1 fixes this.

@maurosampietro
Copy link

maurosampietro commented May 22, 2017

I was going exactly to fix that, fortunately i checked the issue before starting.

Your fix could be further enhanced by separating logic and wprints. (introducing internal return states and handling them separately. in this case displaying a message to the user.)

@deltabeard
Copy link
Author

I didn't make the pull request. You should comment your suggested changes on the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants