Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider splitting appengine-magic to multiple libraries #75

Open
nukemberg opened this issue Aug 24, 2013 · 1 comment
Open

Consider splitting appengine-magic to multiple libraries #75

nukemberg opened this issue Aug 24, 2013 · 1 comment

Comments

@nukemberg
Copy link
Contributor

while working on 1.8.x sdk support i encountered a classloader error in the dev server:

java.lang.ClassCastException: com.google.appengine.tools.development.ApiProxyLocalImpl cannot be cast to com.google.appengine.tools.development.ApiProxyLocal

This was caused by com.google.appengine/appengine-api-stubs and com.google.appengine/appengine-testing dependencies being copied into the war file. while it's simple enough to exclude these in appengine-prepare lein task, the correct solution would be to separate runtime dependencies from lein plugin and test dependencies.
I suggest splitting appegine-magic to 3 libraries - lein-appengine-magic, appengine-magic and appengine-magic-testing so that users can add dependencies to lein profiles as needed.

@gcv
Copy link
Owner

gcv commented Jan 29, 2014

This is probably a good idea. When I have time to work on appengine-magic, I'll probably do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants