Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick v1.29] Updated NodeGroupAutoscalingOptions to now include all options (#310) #313

Merged
merged 1 commit into from
Jul 4, 2024
Merged

[cherry-pick v1.29] Updated NodeGroupAutoscalingOptions to now include all options (#310) #313

merged 1 commit into from
Jul 4, 2024

Conversation

aaronfern
Copy link

What this PR does / why we need it:
This PR cherry picks #310

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixed a bug where some default NodeGroupAutoscalingOptions were not considered

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Jul 4, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 4, 2024
rishabh-11
rishabh-11 approved these changes Jul 4, 2024
View reviewed changes
Copy link

@rishabh-11 rishabh-11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rishabh-11 rishabh-11 merged commit 4e6ceff into gardener:rel-v1.29 Jul 4, 2024
10 checks passed
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging status/closed Issue is closed (either delivered or triaged) and removed needs/review Needs review labels Jul 4, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rishabh-11 rishabh-11 rishabh-11 approved these changes

@himanshu-kun himanshu-kun Awaiting requested review from himanshu-kun

@unmarshall unmarshall Awaiting requested review from unmarshall unmarshall is a code owner

Assignees

@aaronfern aaronfern

Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aaronfern @rishabh-11 @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot