Added Madge Builder to graph commonJS/AMD dependencies. #4
Conversation
…kage.json for distribution with npm. Created a build file to minify clientlib. Renamed js to lib to match npm BP. Updated index to show Madge graph.
…kage.json for distribution with npm. Created a build file to minify clientlib. Renamed js to lib to match npm BP. Updated index to show Madge graph.
| @@ -0,0 +1,3 @@ | |||
| .idea | |||
There was a problem hiding this comment.
Please don't commit that file.
There was a problem hiding this comment.
The reason I created this file, is that during npm's publishing process it misses the dist folder due to it being in my .gitignore file. https://www.npmjs.org/doc/developers.html
You could create an empty .gitignore file so that it doesn't use by default what is in .gitignore.
|
Sorry, I can't even review this PR. Please submit only atomic changes. Your PR mixes minification (which I don't need), package.json (why not), madge (why not). You should split it into separate PRs. |
|
The minification is added as process of npm packaging. If you do not wish to add minification as part of npm's publishing process then by all means remove it. |
|
I'll add the madgeBuilder as a separate PR. The package.json automates minification via the build.js script using the npm package command. |
|
I moved the javascript to the lib folder to closer match to NPM best practice, this makes it difficult to give you atomic PR's. The overall reason for this PR was so that DependencyWheel could be included into Cloudflare's JS CDN https://github.com/cdnjs/cdnjs. The package.json file includes the npmFile Map attribute that points to a built (dist) version of the library- only the files listed here are added to the CDN. Cloudflare has a requirement for minification, so I built that as part of the npm packaging process which makes it automated. All you should need to do to submit this package to npm is, after the package.json file has been merged to run the following commands: npm install -d && npm adduser && npm package |
Added npm package.json for distribution with npm. Created a build file to minify clientlib. Renamed js to lib to match npm BP. Updated index to show Madge graph.