Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more details to what _MAX_AHEAD_SCHEDULE is for #16

Open
llucax opened this issue Mar 26, 2024 · 4 comments
Open

Add more details to what _MAX_AHEAD_SCHEDULE is for #16

llucax opened this issue Mar 26, 2024 · 4 comments

Comments

@llucax
Copy link
Contributor

llucax commented Mar 26, 2024

I didn't understand which issue this is trying to solve, maybe we need a more detailed explanation of the issue and how this solves it.

Originally posted by @llucax in #9 (comment)

@llucax llucax mentioned this issue Mar 26, 2024
@Marenz
Copy link
Contributor

Marenz commented Jun 3, 2024

Is the existing documentation sufficient?

The exact value is not important, but should be a few hours and not more than a day.

@llucax
Copy link
Contributor Author

llucax commented Jun 3, 2024

To me, no. That doesn't say what is it for and what's the effect on changing it.

@Marenz
Copy link
Contributor

Marenz commented Jun 3, 2024

Really? What more would you need from the description?

"""The maximum time ahead to schedule a dispatch.

We don't want to schedule dispatches too far ahead,
as they could start drifting if the delay is too long.

This also prevents us from scheduling too many dispatches at once.

The exact value is not important, but should be a few hours and not more than a day.

It describes the effect if it's too long and why it's there?

@llucax
Copy link
Contributor Author

llucax commented Jun 3, 2024

Reading the whole description doesn't help a lot. What does it mean to "schedule a dispatch too far ahead" (or just "ahead")? I don't understand if you are scheduling the dispatches in the future? Also what does it mean exactly to "schedule a dispatch", it means you add it to some list so it is checked periodically to see if it ready to run or what?

Also drifting with respect to what? Why does this prevents scheduling too many dispatches at once?

I think a time diagram might help here, but I'm still uncertain because I still don't understand what this does :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants