Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment terminates on special character #27

Closed
Aman-Codes opened this issue Dec 18, 2020 · 8 comments · Fixed by #28
Closed

Comment terminates on special character #27

Aman-Codes opened this issue Dec 18, 2020 · 8 comments · Fixed by #28

Comments

@Aman-Codes
Copy link
Contributor

Description

Nirjas terminates the comment on occurrence of any special character out of !$%&{}~`"'| for all languages

How to Test

Create a c file and add a single line comment which contains any special character out of !$%&{}~`"'|

How to Resolve

Changing regex from (\/\/\s*[\w #\.()@+-_*\d]*) to (\/\/\s*[\w #\.()@!-~*\d]*)

@GMishx
Copy link
Member

GMishx commented Dec 18, 2020

I am currently working on it. I changed the regex from list of acceptable characters to a simple .*

Will have to test if it fails somewhere.

@Aman-Codes
Copy link
Contributor Author

Aman-Codes commented Dec 18, 2020

I am currently working on it. I changed the regex from list of acceptable characters to a simple .*

Sounds good

@codeakki
Copy link

May i work on this issue I'm a newbie nd want to explore how open source community works nd want to implement my learning skiils

@GMishx
Copy link
Member

GMishx commented Dec 28, 2020

Thanks for your interest @codeakki but #28 already solves it.

@codeakki
Copy link

@GMishx sir is thier is anything where i start my contribution in these project or organisation for ne

@codeakki
Copy link

codeakki commented Dec 28, 2020 via email

@hastagAB
Copy link
Member

Hi @codeakki, You can start with these:

[Good first issues in FOSSology]

[Open issues in Atarashi]

Currently Nirjas has no unattended issues open but you can explore the project to find some.

@GMishx
Copy link
Member

GMishx commented Dec 29, 2020

Thanks for the inputs @hastagAB . I have just created another issue fossology/atarashi#77 and would like to add it to your list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants