fixed button allignment #659 #694
Conversation
There was a problem hiding this comment.
Hi @ayush2999 Thanks for the PR. You have to mention the issue number in the PR description and not the PR title. this is so to link the PR with the issue. Also you need to provide deployed link.
index.html
Outdated
| @@ -527,10 +529,11 @@ <h1>Proudly developed at FOSSASIA</h1> | |||
| <h1>Android Apps of FOSSASIA</h1> | |||
| </div> | |||
| </div> | |||
| <div class="row"> | |||
| <div class="row" > | |||
index.html
Outdated
|
|
||
| <div class="col-md-4 col-sm-6 col-xs-12 sponsor-column" > | ||
| <div class=" text-center" style="margin-bottom: 30px"> | ||
| <!-- <div class=" text-center" style="margin-bottom: 30px;"> --> |
index.html
Outdated
| <a href="https://github.com/fossasia?utf8=✓&q=pslabhttps://github.com/fossasia?utf8=✓&q=pslab" class="btn" target="_self">PSLab GitHub</a> | ||
| <a href="https://fossasia.com" class="btn btn-hollow" target="_self">Buy PSLab</a> | ||
| </div> | ||
|
|
There was a problem hiding this comment.
Please make sure to keep the changes min in your PR for a particular issue.
There was a problem hiding this comment.
This line does not do anything so not needed.
index.html
Outdated
|
|
||
| <div class="col-md-4 col-sm-6 col-xs-12 sponsor-column" > | ||
| <div class=" text-center" style="margin-bottom: 30px"> | ||
| <!-- <div class=" text-center" style="margin-bottom: 30px;"> --> | ||
| <div class=" text-center" style="margin-bottom: 30px;"> |
|
Also there is already a PR for this issue which is inactive but under ongoing review. |
|
Thanks...for highlighting my mistake. How would i get to know that the
particular issue had solved abd it's under review?
I'll make sure to avoid these mistakes in my future PR's
…On Wed 29 Apr, 2020, 6:48 PM CHAITANYA, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In index.html
<#694 (comment)>:
> @@ -527,10 +529,11 @@ <h1>Proudly developed at FOSSASIA</h1>
<h1>Android Apps of FOSSASIA</h1>
</div>
</div>
- <div class="row">
+ <div class="row" >
additional changes.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#694 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALDWE3FKL6HF4MHIMIK3UM3RPASJHANCNFSM4MTSZRHQ>
.
|
It will be showing in issue page that a PR has been filed. but it will only show when you link the issue number in the PR description. Go to this link #659 and you will see a PR filed just above your comment. |
|
@ayush2999 although that PR is inactive so i believe that there would be no problem if you do a PR. |
|
ok..sure |
ghost
closed this
ghost
reopened this
|
issue: #659 |
|
Sorry it was(custom.css) deleted by mistake, i m trying to delete that commit:6079a30908afbaca0e7157f315c1a2412450eeab |
use reset command. |
|
Please resolve conflicts. |
align button on center when the screen is small...this is my first commit if anyone notices some mistake please let me know