Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phone validation not functioning properly #639

Open
plxity opened this issue Dec 28, 2018 · 7 comments
Open

Phone validation not functioning properly #639

plxity opened this issue Dec 28, 2018 · 7 comments

Comments

@plxity
Copy link
Member

plxity commented Dec 28, 2018

Actual Behaviour

In the phone number field, when more than 6 digits are entered for any country. "Invalid phone number" error goes away.

Expected Behaviour
For every country, It should check if the number is valid or not.

Steps to reproduce it

  1. Visit https://accounts.susi.ai/settings
  2. Click on the mobile tab and enter more than 6 digits for any country.

Screenshots of the issue

capture

Would you like to work on the issue?
Yes, I would like to work on this issue.

@plxity
Copy link
Member Author

plxity commented Dec 28, 2018

@anshumanv https://www.npmjs.com/package/react-phone-number-input
I think using this npm module will solve this issue.
What do you suggest?

@piyushimraw
Copy link
Contributor

how about writing a regex to verify that

@plxity
Copy link
Member Author

plxity commented Dec 29, 2018

@piyushimraw We can do that but we have to write it for every country.
This npm module already has the functionality to verify the Phone number for every country.

@piyushimraw
Copy link
Contributor

@plxity Ok cool Go ahead 👍

@sakshee-19
Copy link
Contributor

Since there is no activity for so long I would like to work on this issue.

@plxity
Copy link
Member Author

plxity commented Feb 6, 2019

@sakshee-19 Apparently I'm waiting for mentor's view. Please check the earlier message.
I'm working on this issue. Thanks.

@sakshee-19
Copy link
Contributor

ok fine 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants