Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TargetPool.get_health should return better output #399

Open
Temikus opened this issue Jul 17, 2018 · 1 comment
Open

TargetPool.get_health should return better output #399

Temikus opened this issue Jul 17, 2018 · 1 comment

Comments

@Temikus
Copy link
Member

Temikus commented Jul 17, 2018

Currently:

target_pool.get_health(server.name)
=> {"https://www.googleapis.com/compute/v1/projects/REDACTED/zones/us-central1-f/instances/fog-test-1-testtargetpools-test-get-health"=>
  [{:health_state=>"UNHEALTHY",
    :instance=>"https://www.googleapis.com/compute/v1/projects/REDACTED/zones/us-central1-f/instances/fog-test-1-testtargetpools-test-get-health"}]}

or without parameters

 target_pool.get_health()
=> {"https://www.googleapis.com/compute/v1/projects/REDACTED/zones/us-central1-f/instances/fog-test-1-testtargetpools-test-get-health"=>
  [{:health_state=>"UNHEALTHY",
    :instance=>"https://www.googleapis.com/compute/v1/projects/REDACTED/zones/us-central1-f/instances/fog-test-1-testtargetpools-test-get-health"}],
 "https://www.googleapis.com/compute/v1/projects/REDACTED/zones/us-central1-f/instances/fog-test-2-testtargetpools-test-get-health"=>[]}

Ideally this should just return state:

  • HEALTHY
  • UNHEALTHY
  • UNKNOWN
    , that's it.

Or, at the very least the target_pool.get_health(server.name) should not return the self link twice.

P.S. Notice the '=>[]' for the second instance. Apparently that means "No instance health info was found." That's new to me 😕

@github-actions
Copy link

This issue has been marked inactive and will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants