Hold and video upgrade fixed #503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where as before i was using _sendReinvite() for the video upgrade, the video upgrade logic was interfering with the hold logic. Now i have reverted _sendReinvite() back to how it was and introduced a new _sendVideoUpgrade() for a seperation of concern.
Tested on a FreePBX server that hold is now working. Also to note a few people have said the other side doesnt get notified if they're put on hold. This actually does work with this package but their problem is a PBX problem specifically they havent set moh_passthrough = yes on their endpoints. With that configuration I observer the other side displaying that they had been put on hold by the remote.
This also fixed #492 where event handlers were unneccesarily being introduced.
and #473 with the hold get media types error.