Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since stuck at -1 after rebuild #10

Open
christianbundy opened this issue Feb 8, 2019 · 2 comments
Open

Since stuck at -1 after rebuild #10

christianbundy opened this issue Feb 8, 2019 · 2 comments
Assignees
@christianbundy
Labels
bug

Comments

@christianbundy
Copy link
Member

I haven't been able to debug this completely, but I wanted to make a note (and a TODO for future me) that when running flumeview.rebuild() on this plugin it just remains at -1 until you restart ssb-server, at which point it indexes correctly. I've noticed this in the last view from ssb-db and the contacts2 view from ssb-friends.
@christianbundy christianbundy self-assigned this Feb 8, 2019
christianbundy added a commit to fraction/flumedb-delete that referenced this issue Feb 8, 2019
@christianbundy
Implement working deletion with server.js
b669542 
The only caveat is that two indexes, `last` and `contacts2`, depend on
flumeview-reduce, which seems to require a restart after
`flumeview.rebuild()` before indexing starts again.

See flumedb/flumeview-reduce#10

Also, this throws a handful of "errors" when the rebuild request is
started, but they seem to be harmless. I'll add the errors as a comment
in the PR (#4).
@christianbundy christianbundy mentioned this issue Feb 8, 2019
Closed
@dominictarr
Copy link
Collaborator

hmm, interesting. the thing we really need here is test coverage for this, and things like this.
every flumeview implements rebuild. I've been thinking about this again after setting up integration tests for the ssb stack. Nothing there tests the rebuild stuff though.

@christianbundy christianbundy mentioned this issue Mar 27, 2019
Closed
34 tasks
@christianbundy
Copy link
Member Author

Started adding rebuild() tests to SSB-DB and I noticed that all but one view is finishing the rebuild process. After some investigation, I found this issue again -- woo! Gonna work on this a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christianbundy christianbundy

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dominictarr @christianbundy